Re: [PATCH 1/1] Make git archive respect core.autocrlf when creating ...

From: Charles Bailey <charles@hashpling.org>
Date: Sep 18, 2008, 20:29 UTC
Message-ID: <20080918202929.GA9948@hashpling.org>
In-Reply-To: <48D2B831.8080206@op5.se>

On Thu, Sep 18, 2008 at 10:21:05PM +0200, Andreas Ericsson wrote:

> If it fixes the broken test while all the other tests still
> pass, I can only assume it's doing something right.

Only if you believe that I added a sensible test in the first place :-)

> The topic is a bit long though. Could you change it to
> "git archive: respect core.autocrlf when creating zip archives"
> so that it fits comfortably in one line when running "git log"
> on 80 char wide terminals?

Sorry, I made it <= 72 chars in my commit message and then forgot that git format-patch adds the [PATCH] tag.

> As a side-note, you needn't put "1/1" in the [PATCH] section.
> That's usually done to make sure patches are applied in the
> right order when sending a series, but since a series of 1
> is kinda hard to jumble.. ;-)

I thought that the patch (a single commit) didn't really warrant a patch series - being a one liner - but I made the test 0 of 1 so that people could see the test failure first before deciding whether my proposed patch was good or not. Sorry for the confusion.

Charles.