Re: [PATCH] git-svn: do a partial rebuild if rev_map is out-of-date

From: Eric Wong <normalperson@yhbt.net>
Date: Sep 18, 2008, 06:38 UTC
Message-ID: <20080918063754.GA13328@untitled>
In-Reply-To: <20080917031304.GA2505@riemann.deskinm.fdns.net>

Deskin Miller <deskinm@umich.edu> wrote:

Show 9 quoted lines

> This commit will have git-svn do a partial rebuild of the rev_map to
> match the true state of the branch, if it ever is used to fetch again.
> 
> This will only work for projects not using either noMetadata or
> useSvmProps configuration options; if you are using these options,
> git-svn will fall back to the previous behaviour.
> 
> Signed-off-by: Deskin Miller <deskinm@umich.edu>
> ---

Hi Deskin,

This seems to break the following test case for me:

*** t9107-git-svn-migrate.sh ***
*   ok 1: setup old-looking metadata
*   ok 2: git-svn-HEAD is a real HEAD
*   ok 3: initialize old-style (v0) git svn layout
*   ok 4: initialize a multi-repository repo
*   ok 5: multi-fetch works on partial urls + paths
*   ok 6: migrate --minimize on old inited layout
* FAIL 7: .rev_db auto-converted to .rev_map.UUID

I haven't had time to diagnose it. Also, can you add a test that demonstrates this functionality (and ensures things keeps working when future work is done on git-svn?)

Thanks.

-- 
Eric Wong