Re: [StGit PATCH] Convert "sink" to the new infrastructure

From: Karl Hasselström <kha@treskal.com>
Date: Sep 17, 2008, 13:04 UTC
Message-ID: <20080917130432.GA26365@diana.vm.bytemark.co.uk>
In-Reply-To: <b0943d9e0809170455m53eaf677t87e9ade3f001d044@mail.gmail.com>

On 2008-09-17 12:55:39 +0100, Catalin Marinas wrote:

Show 8 quoted lines

> 2008/9/16 Karl Hasselström <kha@treskal.com>:
>
> > When benchmarking recent StGits, you'll want to try goto as well,
> > since push and pop are not yet new-infrastructure-ized (meaning
> > they're getting slowdowns from the stack log, but no speedups (if
> > any) from the new infrastructure).
>
> Indeed, goto is faster even than the stable branch.

When push+pop are converted to the new infrastructure, their performance should be identical to goto's.

> I attached the new figures. I think it could go even faster if
> pushing attempts a "git apply" first before the index merge. With
> the stack log, the patch diff should be saved already so no need for
> a "git diff" (as in the stable branch).

Actually, the new infrastructure already uses apply (with fall-back to merge-recursive). It doesn't use the saved diff, though.

> 2.6.27-rc5-mm1 kernel, 300 patches uncommitted
>
> pop/push ran a few times to heat the caches before running the
> benchmarks.

Have you tried the benchmarks I committed a while back?

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle