Re: [PATCH] Optional shrinking of RCS keywords in git-p4
- From
David Brown <git@davidb.org>
- Date
- Sep 15, 2008, 06:35 UTC
- Message-ID
- <20080915063521.GA1533@linode.davidb.org>
- In-Reply-To
- <16219.81556.qm@web95005.mail.in2.yahoo.com>
On Mon, Sep 15, 2008 at 11:56:22AM +0530, dhruva wrote:
>8. The git diffs is now not aware of the change in RCS keyword >9. You try to submit your local changes back to p4 >10. Applying your local changes as patch sets will fail with missing hunks tracking RCS keyword changes
It sounds like you are trying to apply these as patches to a tree which doesn't have RCS headers. As far as I can tell, P4 completely ignores whatever the $Id: ...$ headers happen to be expanded to at the time of checking. You can put garbage there, and it check in fine.
I've been checking in files for many years with stripped headers. I wrote a python script years ago to strip the P4 headers after Perforce was unwilling to implement this as an option.
I guess it isn't a problem to make this optional in git-p4, but I don't think this patch is solving the right problem.
David