Re: [ANNOUNCE] GIT 1.6.0-rc2

From: David Miller <davem@davemloft.net>
Date: Sep 13, 2008, 08:33 UTC
Message-ID: <20080913.013330.29519747.davem@davemloft.net>
In-Reply-To: <20080807.052648.239243998.davem@davemloft.net>

From: David Miller <davem@davemloft.net>
Date: Thu, 07 Aug 2008 05:26:48 -0700 (PDT)

Show 17 quoted lines

> From: Junio C Hamano <gitster@pobox.com>
> Date: Thu, 07 Aug 2008 03:00:25 -0700
> 
> > Peter Zijlstra <peterz@infradead.org> writes:
> > 
> > > Quick question - where does one go to find out the cool new features
> > > that make it 1.6 and should convince me to upgrade and try this whicked
> > > new release?
> > 
> > Draft release notes for 1.6.0 was posted to the list some time ago
> > already, but as always:
> > 
> >     http://www.kernel.org/pub/software/scm/git/docs/RelNotes-1.6.0.txt
> 
> Just FYI, I have some issue with 1.6.x git when pulling remotely from
> it on sparc64.  I suspect it is the usual unaligned access issue and I
> will debug it further soon.

As a followup this turned out to be the classic "PATH when doing GIT over SSH" problem.

I have to say this is very unfun to debug, and even less fun to "fix" even once you know this is the problem. And what's more I know this is the second time I've had to spend a night debugging this very problem.

I ended up having to make a ~/.ssh/environment file and then restart my SSH server with "PermitUserEnvironment yes" added to sshd_config.

But I can't believe this is what I have to do just to pull from a machine where I have GIT only installed in my home directory. What if I were just a normal user and couldn't change the SSHD config? What hoops would I need to jump through to get my PATH setup correctly? :)

It doesn't even work to put ~/bin into the PATH listed in the system wide /etc/environment, because that does not do tilde expansion, SSHD just takes it as-is.

Wouldn't it make sense to put the bindir into PATH when we try to do execv_git_cmd()? The code has already put the gitexecdir into the PATH at this point.

Thanks!