git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [JGIT PATCH] RevWalk: Fix RevSort.REVERSE combined with RevSort.TOPO

From
Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Date
Sep 7, 2008, 21:21 UTC
Message-ID
<200809072321.59789.robin.rosenberg.lists@dewire.com>
In-Reply-To
<1220821208-13420-1-git-send-email-spearce@spearce.org>
söndagen den 7 september 2008 23.00.08 skrev Shawn O. Pearce:
Show 5 quoted lines
> From: Shawn O. Pearce <sop@google.com>
> 
> The reverse sort was using the initial pending queue, not the
> generator that comes before it in the workflow.  This caused
> a combination of TOPO and REVERSE to return no commits.

Some unit tests to back this up would be nice. We running low on coverage in this section of code.

> Signed-off-by: Shawn O. Pearce <sop@google.com>

No idea Google employees had this short email addresses. Ok, 27x27x27 = 19683 would be sufficient in theory, I'd suppose.

-- robin
Previous: Shawn O. PearceNext: Shawn O. Pearce
Message 3 of 4 in “RevWalk: Fix RevSort.REVERSE combined with RevSort.TOPO”
  1. RevWalk: Fix RevSort.REVERSE combined with RevSort.TOPOShawn O. Pearce, Sep 7, 2008
  2. Shawn O. PearceSep 7, 2008
  3. Robin RosenbergSep 7, 2008
  4. Shawn O. PearceSep 7, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.