Re: [JGIT PATCH 2/2] Move pathOf to RepositoryTestCase and use it for locating test files

From: Jonas Fonseca <fonseca@diku.dk>
Date: Sep 3, 2008, 21:48 UTC
Message-ID: <20080903214818.GB6316@diku.dk>
In-Reply-To: <20080903170904.GB28315@spearce.org>

Shawn O. Pearce <spearce@spearce.org> wrote Wed, Sep 03, 2008:

Show 11 quoted lines

> Jonas Fonseca <fonseca@diku.dk> wrote:
> >  This is a workaround patch disguised as a cleanup patch. For NetBeans I
> >  am not yet sure how to setup JGit as a project where everythng works.
> >  For now I need to be able to override the path to files used by the
> >  tests and this patch reduces that change to one single place.
> 
> I wonder if we shouldn't just prod Imran to finish the Maven stuff.
> He has some patches in there that are specifically for this same
> issue under Maven.
> 
>   http://repo.or.cz/w/egit/imyousuf.git?a=shortlog;h=refs/heads/mavenize-jgit

I think the patch is a nice cleanup, even if it is a workaround. But anything that will help to make the build system more shell friendly is greatly appreciated.

-- 
Jonas Fonseca