Re: [PATCH 0/4] tests: use "git xyzzy" form

From: Jeff King <peff@peff.net>
Date: Sep 3, 2008, 20:59 UTC
Message-ID: <20080903205945.GA32413@coredump.intra.peff.net>
In-Reply-To: <7vwsht9cw5.fsf@gitster.siamese.dyndns.org>

On Wed, Sep 03, 2008 at 01:45:46PM -0700, Junio C Hamano wrote:

> Doing this _carefully_ (otherwise the result would be useless) must have
> been quite a lot of effort, and what was posted seems to have been done
> quite carefully.

Yes, thank you Nanako. After complaining about it to Junio, I expected I would have to be the one to do it. But procrastination pays off once again...

Show 5 quoted lines

> The cross-checking I did with "grep" in this message does *not* catch if
> you converted something that shouldn't have been converted (e.g. changing
> the pathname ".git/rebase-merge/git-rebase-todo" to "git rebase-todo"
> would have been a disaster).  It needs real eyeballing of the patches
> themselves to catch such an error, and we would need help from people.

When I did this the last time, I recall that most of the errors of that sort tended to make the test fail loudly. So that is a point in our favor. However, I agree that eyeballing is a good strategy here.

I just checked 1/4, which looks fine. Made much easier by the use of --color-words (even easier with -U0, but sometimes the context is helpful for seeing that it is correct).

In 2/4, we change some instances of git-upload-pack, which you otherwise mentioned in your "should be left". It's in t5530 and t5602. Otherwise looks fine.

-Peff