Re: [EGIT PATCH 1/2] Add utilities for figuring out repositories for selected resources

From: Shawn O. Pearce <spearce@spearce.org>
Date: Sep 2, 2008, 15:03 UTC
Message-ID: <20080902150323.GC28704@spearce.org>
In-Reply-To: <1220175524-1523-2-git-send-email-robin.rosenberg@dewire.com>

Robin Rosenberg <robin.rosenberg@dewire.com> wrote:

> We want to go from selected resources to repositories and back
> to any resource in those repositories

...

Show 8 quoted lines

> +	protected Repository[] getRepositoriesFor(final IProject[] projects) {
> +		Set<Repository> ret = new HashSet<Repository>();
> +		for (IProject project : projects) {
> +			RepositoryMapping repositoryMapping = RepositoryMapping.getMapping(project);
> +			if (repositoryMapping == null)
> +				return new Repository[0];
> +			ret.add(repositoryMapping.getRepository());
> +		}

Hmm. So if any one of the selected projects doesn't have a Git repository at its top level we just plain fail and pretend none of them have a Git repository? That doesn't seem right to me. We should just skip that project and move to another project.

But I also wonder if that really makes sense when a project could have a linked resource under it that points to the repository's working directory. In such cases we want operations on that project to potentially impact the inner repository as maybe the project repository does not have a repository itself. IOW I'm questioning the idea of getRepositoriesFor(getProjectsForSelectedResources()).

-- 
Shawn.