Re: [PATCH] fast-import: add ignore non-existent files option.

From: Shawn O. Pearce <spearce@spearce.org>
Date: Sep 2, 2008, 04:39 UTC
Message-ID: <20080902043951.GB13248@spearce.org>
In-Reply-To: <94a0d4530809011552h59e476e0q9033f0b917288a8f@mail.gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> wrote:

Show 20 quoted lines

> On Tue, Sep 2, 2008 at 1:38 AM, Shawn O. Pearce <spearce@spearce.org> wrote:
> > Felipe Contreras <felipe.contreras@gmail.com> wrote:
> >> This is useful for SCMs that don't have proper changesets in each
> >> revision (monotone).
> >
> >> +--tolerant::
> >> +     Avoid fatal exceptions when actions are executed in non-existent
> >> +     files.  For example removing a file that is not there.
> >> +
> >
> > Yea.  But I'm not sure --tolerant is the best name.  --ignore-errors
> > or --treat-errors-as-warnings sounds better to me.
> 
> I initially named it --ignore-non-existent, but I thought the option
> was too specific.
> 
> --ignore-errors or --treat-errors-as-warnings imply all errors. It
> might make sense to always fail at certain errors, like 'mark not
> found'. I thought 'relaxed' or 'tolerant' would imply that only some
> errors will be allowed, not all.

OK, that argument makes sense. Then I wonder if more specific error ignoring would be better:

  --ignore-error=already-deleted
  --ignore-error=already-deleted,missing-mark,missing-copy-source

I'm not really fond of turning an existing error condition that exists to catch broken frontends into a generic tolerant flag. But being able to selectively turn it off while leaving other errors as errors isn't entirely unreasonable.

-- 
Shawn.