git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [EGIT PATCH 2/3] Handle NoRemoteRepositoryException in PushOperation especially

From
Shawn O. Pearce <spearce@spearce.org>
Date
Aug 28, 2008, 02:19 UTC
Message-ID
<20080828021936.GA8624@spearce.org>
In-Reply-To
<1219887370-17265-2-git-send-email-marek.zawirski@gmail.com>
Marek Zawirski <marek.zawirski@gmail.com> wrote:
Show 23 quoted lines
> diff --git a/org.spearce.egit.core/src/org/spearce/egit/core/coretext.properties b/org.spearce.egit.core/src/org/spearce/egit/core/coretext.properties
> index 94cf4aa..04ca28f 100644
> --- a/org.spearce.egit.core/src/org/spearce/egit/core/coretext.properties
> +++ b/org.spearce.egit.core/src/org/spearce/egit/core/coretext.properties
> @@ -61,5 +61,6 @@ ListRemoteOperation_title=Getting remote branches information
>  PushOperation_resultCancelled=Operation was cancelled.
>  PushOperation_resultNotSupported=Can't push to {0}
>  PushOperation_resultTransportError=Transport error occured during push operation: {0}
> +PushOperation_resultNoServiceError=Push service is not available: {0}
>  PushOperation_taskNameDryRun=Trying pushing to remote repositories
>  PushOperation_taskNameNormalRun=Pushing to remote repositories
> diff --git a/org.spearce.egit.core/src/org/spearce/egit/core/op/PushOperation.java b/org.spearce.egit.core/src/org/spearce/egit/core/op/PushOperation.java
> index 8811800..a0f2e5c 100644
> --- a/org.spearce.egit.core/src/org/spearce/egit/core/op/PushOperation.java
> +++ b/org.spearce.egit.core/src/org/spearce/egit/core/op/PushOperation.java
> @@ -125,6 +126,10 @@ public void run(IProgressMonitor monitor) throws InvocationTargetException {
>  				final PushResult pr = transport.push(gitSubMonitor,
>  						specification.getRefUpdates(uri));
>  				operationResult.addOperationResult(uri, pr);
> +			} catch (final NoRemoteRepositoryException e) {
> +				operationResult.addOperationResult(uri, NLS.bind(
> +						CoreText.PushOperation_resultNoServiceError, e
> +								.getMessage()));
Isn't this when combined with the prior patch going to result in a message like:
	Push service is not available: git://repo.or.cz/egit.git push service is not available
which is sort of redundant and confusingly redundant, isn't it?
-- 
Shawn.
Previous: Marek ZawirskiNext: Marek Zawirski
Message 6 of 10 in “Give NoRemoteRepositoryException better message in BasePackConnection”
  1. 1/3 Give NoRemoteRepositoryException better message in BasePackConnectionMarek Zawirski, Aug 28, 2008
  2. 2/3 Handle NoRemoteRepositoryException in PushOperation especiallyMarek Zawirski, Aug 28, 2008
  3. 3/3 Show ErrorDialog fot fatal connection errors in ConfirmationPageMarek Zawirski, Aug 28, 2008
  4. Shawn O. PearceAug 28, 2008
  5. Marek ZawirskiAug 28, 2008
  6. Shawn O. PearceAug 28, 2008
  7. Marek ZawirskiAug 28, 2008
  8. Shawn O. PearceAug 28, 2008
  9. Marek ZawirskiAug 28, 2008
  10. Shawn O. PearceAug 28, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.