git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [JGIT PATCH 1/2] index-pack: Avoid disk corruption yielding a valid pack footer checksum

From
Shawn O. Pearce <spearce@spearce.org>
Date
Aug 28, 2008, 00:14 UTC
Message-ID
<20080828001401.GT26523@spearce.org>
In-Reply-To
<alpine.LFD.1.10.0808272007541.1624@xanadu.home>
Nicolas Pitre <nico@cam.org> wrote:
Show 9 quoted lines
> On Wed, 27 Aug 2008, Shawn O. Pearce wrote:
> > 
> >   This was inspired by the data corruption thread started
> >   by J. Bruce Fields.  At some point in the thread Linus
> >   pointed out the C Git index-pack isn't as safe as it can
> >   be, and offered a strategy to fix it.
> 
> I thought it was Nicolas Pitre who offered that strategy?
> Maybe I was mistaken.  ;-)

Sorry about the bad attribution. Going back through the archives does say it was you that had the brilliant idea.

Heh. Well at least my fuzzy memory of recent history is only on the mailing list archives and not in a commit.

;-)
-- 
Shawn.
Previous: Nicolas PitreNext: Nicolas Pitre
Message 4 of 5 in “index-pack: Avoid disk corruption yielding a valid pack footer checksum”
  1. 1/2 index-pack: Avoid disk corruption yielding a valid pack footer checksumShawn O. Pearce, Aug 27, 2008
  2. 2/2 index-pack: Use fsync to ensure received pack data is on diskShawn O. Pearce, Aug 27, 2008
  3. Nicolas PitreAug 28, 2008
  4. Shawn O. PearceAug 28, 2008
  5. Nicolas PitreAug 28, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.