Re: [egit PATCH] avoiding output in the error log

From: Shawn O. Pearce <spearce@spearce.org>
Date: Aug 27, 2008, 22:00 UTC
Message-ID: <20080827220022.GP26523@spearce.org>
In-Reply-To: <200808272350.56819.robin.rosenberg.lists@dewire.com>

Robin Rosenberg <robin.rosenberg.lists@dewire.com> wrote:

Show 10 quoted lines

> > > 
> > > Shawn, you removed the test from the code in 4a230ea1. Perhaps you could care to
> > > comment on this patch to restore the test, though slightly different.
> > > 
> > > 		if (r.isAccessible())
> > > 			r.setSessionProperty(GITFOLDERDIRTYSTATEPROPERTY, null);
> 
> Good. So then the question is whether we should use isAccessible() or exists()? Normally
> this makes no difference, but for a Project (at least) there is a difference. I project that exits
> is not accessible when closed.

It _has_ to be isAccessible(). You cannot get or set a session property on a closed project.

-- 
Shawn.