Re: [PATCH] Makefile: improve customization for supporting HP-UX

From: Miklos Vajna <vmiklos@frugalware.org>
Date: Aug 23, 2008, 22:03 UTC
Message-ID: <20080823220358.GH23800@genesis.frugalware.org>
In-Reply-To: <20080823210243.GB7185@schiele.dyndns.org>

On Sat, Aug 23, 2008 at 11:02:43PM +0200, Robert Schiele <rschiele@gmail.com> wrote:

Show 28 quoted lines

> On Sat, Aug 23, 2008 at 10:26:01PM +0200, Miklos Vajna wrote:
> > On Sat, Aug 23, 2008 at 10:09:28PM +0200, Robert Schiele <rschiele@gmail.com> wrote:
> > > The systems I build on are:
> > > 
> > > 1x HP-UX B.11.11 U 9000/785
> > 
> > This is the same version I'm using at the moment.
> > 
> > The NEEDS_LIBICONV is simple, the linker fails to find iconv symbols:
> > 
> > /usr/ccs/bin/ld: Unsatisfied symbols:
> >    libiconv (first referenced in libgit.a(utf8.o)) (code)
> >    libiconv_open (first referenced in libgit.a(utf8.o)) (code)
> >    libiconv_close (first referenced in libgit.a(utf8.o)) (code)
> > collect2: ld returned 1 exit status
> > gmake: *** [git] Error 1
> 
> Huh?  Where does the "lib" prefix come from on your system?  Do you have some
> custom iconv header file in the way?  On my system I see:
> 
> [13] % nm /usr/lib/libc.2 | grep ^iconv
> iconv               |   1255080|extern|entry  |
> iconv               |   1255112|extern|code   |$CODE$
> iconv_close         |   1254800|extern|entry  |
> iconv_close         |   1254832|extern|code   |$CODE$
> iconv_open          |   1255208|extern|entry  |
> iconv_open          |   1255272|extern|code   |$CODE$
> [14] %

Ah, OK, that is specific to this machine. If you install the libiconv package, then #include <iconv.h> includes /usr/local/include/iconv.h where iconv is a define to libiconv. So that is not needed generally, thanks for pointing out.

> Thus I think the snprintf part of your patch makes sense but the iconv stuff
> seems to be something flawed on your machine.

OK, I'll send a patch with that part only in a bit.