git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] discard revindex data when pack list changes

From
Johan Herland <johan@herland.net>
Date
Aug 22, 2008, 21:57 UTC
Message-ID
<200808222357.04912.johan@herland.net>
In-Reply-To
<alpine.LFD.1.10.0808221540290.1624@xanadu.home>
On Friday 22 August 2008, Nicolas Pitre wrote:
Show 7 quoted lines
> This is needed to fix verify-pack -v with multiple pack arguments.
>
> Also, in theory, revindex data (if any) must be discarded whenever
> reprepare_packed_git() is called. In practice this is hard to trigger
> though.
>
> Signed-off-by: Nicolas Pitre <nico@cam.org>
Tested-by: Johan Herland <johan@herland.net>
Thanks. Works for me :)
Junio: if you added the my testcase, please squash the following into this 
patch before applying:
diff --git a/t/t5300-pack-object.sh b/t/t5300-pack-object.sh
index 339375a..83abe5f 100755
--- a/t/t5300-pack-object.sh
+++ b/t/t5300-pack-object.sh
@@ -186,7 +186,7 @@ test_expect_success \
 			test-2-${packname_2}.idx \
 			test-3-${packname_3}.idx'
 
-test_expect_failure \
+test_expect_success \
     'verify pack -v' \
     'git verify-pack -v	test-1-${packname_1}.idx \
 			test-2-${packname_2}.idx \
-- 
1.6.0.96.g2fad1


Have fun! :)

...Johan


-- 
Johan Herland, <johan@herland.net>
www.herland.net
Previous: Nicolas Pitre
Message 6 of 6 in “[BUG?] 'git verify-pack -v' on multiple packs fails for all but the first pack”
  1. Johan HerlandAug 22, 2008
  2. Johan HerlandAug 22, 2008
  3. Selftest for verifying 'git verify-pack -v' with multiple argumentsJohan Herland, Aug 22, 2008
  4. Nicolas PitreAug 22, 2008
  5. discard revindex data when pack list changesNicolas Pitre, Aug 22, 2008
  6. Johan HerlandAug 22, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.