git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] * remote.c (valid_fetch_refspec): remove useless if-before-free test

From
Alex Riesen <raa.lkml@gmail.com>
Date
Aug 20, 2008, 19:40 UTC
Message-ID
<20080820194002.GC16626@blimp.local>
In-Reply-To
<87k5ecx2pl.fsf@rho.meyering.net>
Jim Meyering, Tue, Aug 19, 2008 20:46:30 +0200:
> We removed a handful of these useless if-before-free tests
> several months ago.  This change removes a new one that snuck back in.

Something used to crash in free when passed NULL. It's one of the reasons why some cross-platform projects have xfree which does the check (sometimes depending on platform). Admittedly, it is a long time since I saw such a platform (some old SunOS it was, I believe).

Previous: Jim MeyeringNext: Jim Meyering
Message 2 of 8 in “* remote.c (valid_fetch_refspec): remove useless if-before-free test”
  1. * remote.c (valid_fetch_refspec): remove useless if-before-free testJim Meyering, Aug 19, 2008
  2. Alex RiesenAug 20, 2008
  3. Jim MeyeringAug 20, 2008
  4. Brandon CaseyAug 20, 2008
  5. Junio C HamanoAug 21, 2008
  6. Brandon CaseyAug 21, 2008
  7. Junio C HamanoAug 21, 2008
  8. remote.c: add a function for deleting a refspec array and use it (twice)Brandon Casey, Aug 22, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.