Re: [PATCH] add a 'pre-push' hook

From: Shawn O. Pearce <spearce@spearce.org>
Date: Aug 19, 2008, 23:39 UTC
Message-ID: <20080819233953.GI24212@spearce.org>
In-Reply-To: <7vy72swpbt.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> wrote:

Show 7 quoted lines

> "Scott Chacon" <schacon@gmail.com> writes:
> 
> > I would be happy to add the name of the branch being updated and the remote
> > we're trying to push to.  Is there interest then, in the patch?
> 
> [...] so you are in a better position to come up with various use cases
> and the set of parameters the hook would need to do its validation job.

And please be careful with the term "parameters" here.

We not too long ago changed receive-pack to use stdin into a hook so we don't have to worry about command line length limitations. Once we start talking about something like push or fetch which can operate on a huge batch of refs at one shot we really should avoid the command line limits if we can.

-- 
Shawn.