Re: [TopGit PATCH/RFC] Do not use mktemp

From: Petr Baudis <pasky@suse.cz>
Date: Aug 12, 2008, 20:44 UTC
Message-ID: <20080812204433.GM10151@machine.or.cz>
In-Reply-To: <Pine.GSO.4.62.0808121309000.18832@harper.uchicago.edu>

Hi,

On Tue, Aug 12, 2008 at 01:14:27PM -0500, Jonathan Nieder wrote:

> Old operating systems may not even have mktemp; less old
> operating systems may have a mktemp which is not compatible with
> the usual post-1.5 version.  Let's try to do without.

  can you give some concrete examples?

  If there are really systems like that, I have nothing against
providing our own mktemp stub, but I'm not really fond of the approach
chosen in this patch. I see no reason why our stub shouldn't be
compatible with mktemp - what strikes me is a lot of code duplication
and arcane umask use at a lot of places, this should be encapsulated in
some mktemp() function.

-- 
				Petr "Pasky" Baudis
The next generation of interesting software will be done
on the Macintosh, not the IBM PC.  -- Bill Gates