git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] Teach git diff-tree --stdin to diff trees

From
Jeff King <peff@peff.net>
Date
Aug 11, 2008, 22:28 UTC
Message-ID
<20080811222836.GA12301@sigill.intra.peff.net>
In-Reply-To
<20080809100049.GB10804@diana.vm.bytemark.co.uk>
On Sat, Aug 09, 2008 at 12:00:49PM +0200, Karl Hasselström wrote:
Show 6 quoted lines
> > And I think it might even be easier to code. ;)
> 
> Not for someone who's almost entirely unfamiliar with the git API.
> Finding the right functions to call takes a lot of time ... which is
> why I decided to chicken out and implement only the subset I actually
> needed. But it can be added later -- perhaps by me.

:) I took a quick look, and I don't think it would be too hard to reuse the logic from the command-line codepath. However, your patches are already in 'next', and I don't see much point doing it the other way unless there is actually some demand for mixed commit/tree input.

-Peff
Previous: Karl HasselströmNext: Karl Hasselström
Message 13 of 14 in “Teach git diff-tree --stdin to diff trees”
  1. 0/3 Teach git diff-tree --stdin to diff treesKarl Hasselström, Aug 8, 2008
  2. 1/3 Refactoring: Split up diff_tree_stdinKarl Hasselström, Aug 8, 2008
  3. 2/3 Teach git diff-tree --stdin to diff treesKarl Hasselström, Aug 8, 2008
  4. Junio C HamanoAug 8, 2008
  5. Karl HasselströmAug 9, 2008
  6. 2/3 Teach git diff-tree --stdin to diff treesKarl Hasselström, Aug 9, 2008
  7. Junio C HamanoAug 9, 2008
  8. Karl HasselströmAug 10, 2008
  9. Junio C HamanoAug 9, 2008
  10. Karl HasselströmAug 9, 2008
  11. Jeff KingAug 8, 2008
  12. Karl HasselströmAug 9, 2008
  13. Jeff KingAug 11, 2008
  14. 3/3 Add test for diff-tree --stdin with two treesKarl Hasselström, Aug 8, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.