Re: [BUG] git diff-tree --stdin doesn't accept two trees

From: Karl Hasselström <kha@treskal.com>
Date: Aug 6, 2008, 11:53 UTC
Message-ID: <20080806115358.GD18336@diana.vm.bytemark.co.uk>
In-Reply-To: <7vwsivusy2.fsf@gitster.siamese.dyndns.org>

On 2008-08-05 13:07:17 -0700, Junio C Hamano wrote:

Show 16 quoted lines

> Karl Hasselström <kha@treskal.com> writes:
>
> > I'm trying to use diff-tree --stdin to diff several trees in one
> > go. But I just get error messages when I feed it two
> > space-separated trees (one commit works fine):
>
> No, the documentation was made wrong during 1.2.0 timeperiod.
>
> The feature of --stdin to take a commit and its parents on one line was
> broken before that to support the common
>
>         rev-list --parents $commits... -- $paths... |
>                 diff-tree --stdin -v -p
>
> usage pattern by Porcelains.  For diff-tree to talk sensibly about
> commits, it needs to see commits, not just trees.

But is there any fundamental reason why it couldn't accept tree-ishes as well? It only talks about commits if asked to do so with command-line options.

Or would that break existing users somehow?

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle