Re: [PATCH] git-cvsimport.perl: Print "UNKNOWN LINE..." on stderr, not stdout.

From: Jeff King <peff@peff.net>
Date: Aug 5, 2008, 15:28 UTC
Message-ID: <20080805152836.GB21901@sigill.intra.peff.net>
In-Reply-To: <87zlnro6kt.fsf@rho.meyering.net>

On Tue, Aug 05, 2008 at 04:54:42PM +0200, Jim Meyering wrote:

> I'm used to filtering git-cvsimport's noisy stderr, but this
> diagnostic appears on stdout.  Looks like an oversight.
> Now that I'm using cvsps-2.2b1, I see tons of these.

There are a ton of things that go to stdout:

  $ perl -ne '/print (\S+)/ && print "$1\n" git-cvsimport.perl |
    grep '^#' | wc -l
  18

though many are only activated via "-v". Maybe it is worth putting all of them to stderr? I really don't see why cvsimport should ever produce any output on stdout.

-Peff