Re: git help broken

From: Christian Couder <chriscool@tuxfamily.org>
Date: Aug 1, 2008, 04:28 UTC
Message-ID: <200808010628.52875.chriscool@tuxfamily.org>
In-Reply-To: <20080731000454.GJ32057@genesis.frugalware.org>

Le jeudi 31 juillet 2008, Miklos Vajna a écrit :

> On Thu, Jul 31, 2008 at 01:44:36AM +0200, Johannes Schindelin

<Johannes.Schindelin@gmx.de> wrote:

Show 8 quoted lines

> > > And from the patch, it is pretty obvious that it does not come close
> > > to the "man" code path.
> >
> > Oh, so it was involved?
>
> Yes. The command list is no longer loaded automatically and the default
> for non-git commands on git help foo was 'gitfoo', I guess for
> gittutorial and such manpages.

Yeah, and it seems that "git help help" doesn't work any more since my patch that does that:

2dce956e397be8a769624e8693565b8a30056060 help: check early if we have a command, if not try a documentation topic

I didn't realize that the function "is_git_command" would not work for "help".

Perhaps there should be another function like is_git_command that could work using the "struct cmd_struct commands" defined in "handle_internal_command" in "git.c". That may be faster and more accurate.

Unfortunately I won't have time to work on this as I will leave for vacation in a few hours. Sorry to leave this behind.

Best regards, Christian.