Re: [PATCH v2] Advertise the ability to abort a commit

From: Jeff King <peff@peff.net>
Date: Jul 30, 2008, 05:11 UTC
Message-ID: <20080730051059.GA4497@sigill.intra.peff.net>
In-Reply-To: <20080730050715.GA4034@sigill.intra.peff.net>

On Wed, Jul 30, 2008 at 01:07:15AM -0400, Jeff King wrote:

Show 7 quoted lines

> > -		die("no commit message?  aborting commit.");
> > +		die("no commit message.  aborting commit.");
> 
> I don't think the change of punctuation makes a big difference here,
> but this could probably stand to be reworded. Maybe:
> 
>   Aborting commit due to empty commit message.

Using "die" also prepends "fatal: " which is perhaps a bit much for an expected feature. So maybe:

  fprintf(stderr, "Aborting commit due to empty commit message.\n");
  exit(1); /* or even some specific "intentional abort" exit code */

-Peff