Re: GIT 1.6.0-rc1

From: Alex Riesen <raa.lkml@gmail.com>
Date: Jul 29, 2008, 21:17 UTC
Message-ID: <20080729211745.GA3879@blimp.local>
In-Reply-To: <7vljzlhyt8.fsf@gitster.siamese.dyndns.org>

Junio C Hamano, Tue, Jul 29, 2008 10:36:19 +0200:

Show 5 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
> >
> > Ok, I took a deeper look at the codepaths involved.  Although it does work
> > around the issue, I do not think your patch alone is the "correct" one in
> > the longer term.

Thought so. I just didn't know the code around

Show 7 quoted lines

> > It needs a bit of explanation, and the explanation won't be exactly
> > "plain, small and short", unfortunately.
> 
> Alex, I ran the full test with this, but only on Linux boxes; obviously
> not on any flavor of Windows.  I think it is correct, and the "first line
> of defence" fix is the same as your patch, so I'd assume it would work for
> you as well.  But extra eyeballs are always appreciated.

Well, it works on Cygwin too. And I had my eyeballs on the code (wondered first if it will cause more fs accesses than before: it will, in the racy check. Which is correct, AFAICT)