git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-gui: Look for gitk in $PATH, not $LIBEXEC/git-core

From
AMAbhijit Menon-Sen <ams@toroid.org>
Date
Jul 24, 2008, 13:28 UTC
Message-ID
<20080724132853.GA25313@toroid.org>
In-Reply-To
<80915B5E107BED488500050294C6F48712136B@ex2k.bankofamerica.com>
Signed-off-by: Abhijit Menon-Sen <ams@toroid.org>
---
At 2008-07-24 09:01:48 -0400, john.murphy@bankofamerica.com wrote:
>
> I presume this was just an oversight when git- commands were removed
> from the bin directory.

Looks like it. The following patch fixes it for me. Does it work for you on Windows?

-- ams
 git-gui/git-gui.sh |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
index 940677c..a70fa67 100755
--- a/git-gui/git-gui.sh
+++ b/git-gui/git-gui.sh
@@ -1670,10 +1670,10 @@ proc do_gitk {revs} {
 	# -- Always start gitk through whatever we were loaded with.  This
 	#    lets us bypass using shell process on Windows systems.
 	#
-	set exe [file join [file dirname $::_git] gitk]
+	set exe [_which gitk]
 	set cmd [list [info nameofexecutable] $exe]
-	if {! [file exists $exe]} {
-		error_popup [mc "Unable to start gitk:\n\n%s does not exist" $exe]
+	if {$exe eq {}} {
+		error_popup [mc "Couldn't find gitk in PATH"]
 	} else {
 		global env
 
-- 
1.5.6.GIT
Previous: Murphy, JohnNext: Shawn O. Pearce
Message 2 of 6 in “Git Gui bug calling gitk”
  1. Murphy, JohnJul 24, 2008
  2. git-gui: Look for gitk in $PATH, not $LIBEXEC/git-coreAbhijit Menon-Sen, Jul 24, 2008
  3. Shawn O. PearceJul 25, 2008
  4. Murphy, JohnJul 29, 2008
  5. Shawn O. PearceJul 29, 2008
  6. Shawn O. PearceJul 30, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.