Re: [PATCH] parse-options: fix parsing of "--foobar=" with no value

From: Pierre Habouzit <madcoder@debian.org>
Date: Jul 22, 2008, 18:54 UTC
Message-ID: <20080722185427.GA10453@artemis.madism.org>
In-Reply-To: <1216752267-12138-1-git-send-email-dkr+ml.git@free.fr>

On Tue, Jul 22, 2008 at 06:44:27PM +0000, Olivier Marin wrote:

Show 6 quoted lines

> From: Olivier Marin <dkr@freesurf.fr>
> 
> Before this patch, running a git command with a "--foobar=" argument
> will set the "foobar" option with a random value and continue.
> We should instead, exit with an error if a value is required, or use
> the default one if the value is optional.

  Wrong, --foobar= is the option "foobar" with the argument "" (empty
string). as soon as you use the --foobar=... form, that is the "stuck
form" for long option, there *is* a value.

  IOW --foobar= is not the same as --foobar at all. If like you claim,
--foobar= pass a "random" value to the option then *this* is a bug, it
should pass a pointer to an empty string (IOW a pointer that points to a
NUL byte), but I see nothing in the code that would explain what you
claim.

-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org