Re: Error: "You have some suspicious patch lines"

From: Jeff King <peff@peff.net>
Date: Jul 22, 2008, 07:26 UTC
Message-ID: <20080722072620.GA3796@sigill.intra.peff.net>
In-Reply-To: <4885895C.5050108@gmail.com>

On Tue, Jul 22, 2008 at 09:16:44AM +0200, Ben Aurel wrote:

Show 14 quoted lines

> -----------------------------------------
>
> Editing '.git/hooks/pre-commit' and comment out the following lines
> --
> 61             if (/^\s* \t/) {
> 62                 bad_line("indent SP followed by a TAB", $_);
> 63             }
> --
>
> And finally "git commit" works again.
>
> The question now is: Is it really necessary to edit the git script  
> everytime? Is there a urgent reason why git refuses to commit because of  
> "suspicious" lines? Is it really necessary?

The pre-commit hook that ships with git checks whitespace as an example of what one _could_ do with hooks. It is not meant to be enabled by default (unless you want that whitespace checking).

So either:

 1. You enabled it by setting the execute bit. If so, then don't do
    that.

 2. Something is broken, and it has caused the hook to be enabled
    accidentally. I recall somebody complaining that hooks were enabled
    by default under cygwin because the filesystem didn't support the
    execute bit. Are you working on an exec-bit challenged filesystem?

In newer versions of git, the hooks actually ship with a .sample extension so that they will not be used accidentally, regardless of the executable bit. In the meantime, it is safe to simply delete .git/hooks/pre-commit if it is bothering you.

-Peff