git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Allow pager of diff command be enabled/disabled

From
Jeff King <peff@peff.net>
Date
Jul 22, 2008, 04:58 UTC
Message-ID
<20080722045806.GD20787@sigill.intra.peff.net>
In-Reply-To
<20080721212849.GB4748@blimp.local>
On Mon, Jul 21, 2008 at 11:28:49PM +0200, Alex Riesen wrote:
Show 9 quoted lines
> See for example, status and show commands. Besides,
> Documentation/RelNotes-1.6.0.txt mentions that pager.<cmd>
> can be used to enable/disable paging behavior per command.
> 
> Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
> ---
> 
> Also, really export check_pager_config, which just got another call
> site.

This patch looks correct to me. There are also a bunch of other commands for which pager.* doesn't work. Basically, anything that doesn't ask for RUN_SETUP is on its own to set up paging if it wants (because Bad Things happen when we try to look in the config before setup has been run).

Most of them people probably don't care about (really, who wants paging by default on git-apply?). But it is yet another hidden inconsistency from the paging patch.

-Peff
Previous: Alex Riesen
Message 2 of 2 in “Allow pager of diff command be enabled/disabled”
  1. Allow pager of diff command be enabled/disabledAlex Riesen, Jul 21, 2008
  2. Jeff KingJul 22, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.