Re: [PATCH/rfc] git-svn.perl: workaround assertions in svn library 1.5.0
- From
- Eric Wong <normalperson@yhbt.net>
- Date
- Jul 21, 2008, 01:29 UTC
- Message-ID
- <20080721012955.GA14129@untitled>
- In-Reply-To
- <20080720201407.GM2925@dpotapov.dyndns.org>
Dmitry Potapov <dpotapov@gmail.com> wrote:
Show 22 quoted lines
> On Sat, Jul 19, 2008 at 06:27:36PM -0700, Junio C Hamano wrote: > > > > So what's the conclusion of this issue? > > > > I'll just revert 2fe403e (git-svn.perl: workaround assertions in svn > > library 1.5.0, 2008-07-06) for 1.6.0-rc0 unless I hear better > > suggestions. > > I have tested the change that I proposed, and it seems to solve the > problem and, as far as I can tell, no other correction is necessary. > Yet, I don't really understand git-svn well, so I could be wrong. > > Reverting 2fe403e will only help users of svn library 1.4, while all > new linux distributives, which will include Git 1.6.0, are going to > install svn library 1.5.0, and if you use svn library 1.5.0, reverting > 2fe403e does not fix anything but only add one more bug. Thus, unless > we are going to require to install git-svn only with svn library 1.4, > reverting this change does not seem to be very helpful for most users. > > So, I hope my patch is better solution... > > Dmitry
Thanks Dmitry,
Your patch works for me on 1.4.3, so if it works with 1.5.0, consider it: Acked-by: Eric Wong <normalperson@yhbt.net>
-- Eric Wong