Re: [RFC PATCH] Support gitlinks in fast-import/export.

From: Shawn O. Pearce <spearce@spearce.org>
Date: Jul 18, 2008, 20:43 UTC
Message-ID: <20080718204338.GB27528@spearce.org>
In-Reply-To: <200807182103.37272.angavrilov@gmail.com>

Alexander Gavrilov <angavrilov@gmail.com> wrote:

Show 6 quoted lines

> Currently fast-import/export cannot be used for
> repositories with submodules. This patch extends
> the relevant programs to make them correctly
> process gitlinks.
> 
> Signed-off-by: Alexander Gavrilov <angavrilov@gmail.com>

Acked-by: Shawn O. Pearce <spearce@spearce.org>

Show 11 quoted lines

> 	I noticed that fast-export & fast-import cannot work with
> 	repositories using submodules: import complains about
> 	an invalid mode, and export fails while trying to open the SHA
> 	as a blob.
> 
> 	As I didn't see any particular reason for it to be so, I tried to
> 	implement support for gitlinks.
> 
> 	What I'm unsure of is, should fast-export try to reuse commit
> 	marks for gitlinks where it happened to recognize the object,
> 	or always output the SHA as it is stored in the tree?

Its unlikely that the commit objects are in the repository the export is running in, so its unlikely you can use a mark. Its fine to just always output the SHA-1 I think.

-- 
Shawn.