Re: [JGIT PATCH 17/28] Support automatic command line parsing for TextBuiltin subclasses

From: Shawn O. Pearce <spearce@spearce.org>
Date: Jul 18, 2008, 20:38 UTC
Message-ID: <20080718203834.GA27528@spearce.org>
In-Reply-To: <4880E880.1010403@web.de>

Florian KKKberle <FloriansKarten@web.de> wrote:

Show 10 quoted lines

> I had a short look at the files and noticed that the inner "if (help) {"
> is unnecessary:
>
> +		if (help) {
> +			System.err.print("jgit ");
> +			System.err.print(commandName);
> +			clp.printSingleLineUsage(System.err);
> +			System.err.println();
> +
> +			if (help) {

Gaaah. Good catch, thanks. I copied and pasted that block from the global option parser to the per-command parser, and then refactored it a little and missed removing this unnecessary inner if test. I'll fix with a rebase.

-- 
Shawn.