git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH (GITK) 3/3] gitk: On Windows use a Cygwin-specific flag for kill.

From
Alexander Gavrilov <angavrilov@gmail.com>
Date
Jul 18, 2008, 05:47 UTC
Message-ID
<200807180947.40515.angavrilov@gmail.com>
In-Reply-To
<200807180946.43560.angavrilov@gmail.com>

MSysGit compiles git binaries as native Windows executables, so they cannot be killed unless a special flag is specified.

This flag is implemented by the Cygwin version of kill, which is also included in MSysGit.

Signed-off-by: Alexander Gavrilov <angavrilov@gmail.com>
---
 gitk |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/gitk b/gitk
index b523c98..d7fea26 100755
--- a/gitk
+++ b/gitk
@@ -388,7 +388,12 @@ proc stop_instance {inst} {
     set fd $commfd($inst)
     catch {
 	set pid [pid $fd]
-	exec kill $pid
+
+	if {$::tcl_platform(platform) eq {windows}} {
+	    exec kill -f $pid
+	} else {
+	    exec kill $pid
+	}
     }
     catch {close $fd}
     nukefile $fd
-- 
1.5.6.2.39.gd084
Previous: Alexander Gavrilov
Message 4 of 4 in “Avoid runaway processes in gitk”
  1. 0/3 Avoid runaway processes in gitkAlexander Gavrilov, Jul 18, 2008
  2. 1/3 gitk: Kill back-end processes on window close.Alexander Gavrilov, Jul 18, 2008
  3. 2/3 gitk: Register diff-files & diff-index in commfd, to ensure kill.Alexander Gavrilov, Jul 18, 2008
  4. 3/3 gitk: On Windows use a Cygwin-specific flag for kill.Alexander Gavrilov, Jul 18, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.