git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Fix nullpointer exceptions in Quickdiff

From
Robin Rosenberg <robin.rosenberg@dewire.com>
Date
Jul 11, 2008, 21:34 UTC
Message-ID
<200807112334.47552.robin.rosenberg@dewire.com>
In-Reply-To
<1215729672-26906-2-git-send-email-robin.rosenberg@dewire.com>

--- I saw some problem when resources were no longer in the worspace, such as during a bisectg. This one should probably just be squashed into patch 1.

-- robin
diff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/decorators/GitDocument.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/decorators/GitDocument.java
index ebed0cf..3724304 100644
--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/decorators/GitDocument.java
+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/decorators/GitDocument.java
@@ -43,7 +43,10 @@ class GitDocument extends Document implements RepositoryListener {
 	void populate() throws IOException {
 		set("");
 		final IProject project = resource.getProject();
-		final String gitPath = RepositoryMapping.getMapping(project).getRepoRelativePath(resource);
+		RepositoryMapping mapping = RepositoryMapping.getMapping(project);
+		if (mapping == null)
+			return;
+		final String gitPath = mapping.getRepoRelativePath(resource);
 		final Repository repository = getRepository();
 		repository.addRepositoryChangedListener(this);
 		String baseline = GitQuickDiffProvider.baseline.get(repository);
@@ -63,7 +66,9 @@ class GitDocument extends Document implements RepositoryListener {
 	}
 
 	void dispose() {
-		getRepository().removeRepositoryChangedListener(this);
+		Repository repository = getRepository();
+		if (repository != null)
+			repository.removeRepositoryChangedListener(this);
 	}
 
 	public void refsChanged(final RefsChangedEvent e) {
@@ -81,6 +86,8 @@ class GitDocument extends Document implements RepositoryListener {
 	private Repository getRepository() {
 		IProject project = resource.getProject();
 		RepositoryMapping mapping = RepositoryMapping.getMapping(project);
-		return mapping.getRepository();
+		if (mapping != null)
+			return mapping.getRepository();
+		return null;
 	}
 }
-- 
1.5.6.2.220.g44701
Previous: Shawn O. PearceNext: Johannes Schindelin
Message 5 of 7 in “Quickdiff improvement”
  1. 0/2 Quickdiff improvementRobin Rosenberg, Jul 10, 2008
  2. 1/2 Make quick diff aware of changes in the repository.Robin Rosenberg, Jul 10, 2008
  3. 2/2 Provide the ability to configure the quickdiff baselineRobin Rosenberg, Jul 10, 2008
  4. Shawn O. PearceJul 11, 2008
  5. Fix nullpointer exceptions in QuickdiffRobin Rosenberg, Jul 11, 2008
  6. EGIT, was Re: [PATCH] Fix nullpointer exceptions in QuickdiffJohannes Schindelin, Jul 11, 2008
  7. Robin RosenbergJul 11, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.