Re: [RFC/PATCH (WIP)] Git.pm: Add get_config() method and related subroutines

From: Petr Baudis <pasky@suse.cz>
Date: Jul 9, 2008, 15:23 UTC
Message-ID: <20080709152340.GK10151@machine.or.cz>
In-Reply-To: <48726D5C.9080801@gmail.com>

On Mon, Jul 07, 2008 at 09:24:12PM +0200, Lea Wiemann wrote:

Show 6 quoted lines

> Jakub Narebski wrote:
> > Git::Repo / Git::Config could use methods / subroutines from Git.pm;
> 
> I don't think that's possible, since Git.pm has a pretty long-running
> (and complicated) instantiation method, whereas Git::Repo has (and must
> have) instantaneous instantiation (without system calls).

There can be an alternative instantiation method that is faster.

> Also, Git.pm is so strange (design-wise) that I'm not very happy with
> depending on it as it is.  I'll write more about that later though.

I'm curious to hear about your reservations to Git.pm design when you get to writing up something. But I think you should have _very_ good reasons for introducing a completely separate alternative API and show convincingly why the current one cannot be extended and build upon, since going that way is bound to get quite messy. Please avoid the NIH syndrome and don't reinvent the wheel needlessly. ;-)

-- 
				Petr "Pasky" Baudis
The last good thing written in C++ was the Pachelbel Canon. -- J. Olson