git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] better git-submodule status output

From
SJSylvain Joyeux <sylvain.joyeux@dfki.de>
Date
Jul 9, 2008, 11:01 UTC
Message-ID
<20080709110154.GC3525@joyeux>
In-Reply-To
<48749215.6070307@op5.se>
On Wed, Jul 09, 2008 at 12:25:25PM +0200, Andreas Ericsson wrote:
Show 36 quoted lines
> Sylvain Joyeux wrote:
>> Here is a (tentative) summary of the whole discussion:
>>
>> * doing fetch in status is EVIL. Therefore, status should only report
>>   whatever information is available.
>> * nonetheless, having a "peek" mode seem to be accepted as a useful
>>   feature not only by me.
>> * changing the output format of git-submodules is not right either,
>>   because it would break existing tools which parses it at the moment.
>>
>> Proposal
>> - remove fetch from status, and make the new output enabled when
>>   --verbose is set (can also be set in the config file I guess).
>>
>>   On the symbols side, I propose:
>>     > submodule commit is a direct descendant of the commit in the
>>       superproject
>>     < submodule commit is a direct ancestor of the commit in the
>>       superproject
>>     + no direct relation between submodule commit and commit in the
>>       superproject
>>     ? the commit in the superproject cannot be found in the submodule
>>       (replaces the initial '!' in my patch)
>>
>>   A 'M' is appended if the submodule has uncommitted changes
>>
>> - define a git-submodule 'fetch' subcommand which call fetch in each
>>   submodule and runs the verbose mode of git-status (can be disabled by
>>   a --quiet option).
>>
>> Comments ? (I'm sure there are some ...)
>>
>
> Re-use the existing symbolism from fetch status output. Using '+' to
> denote "no direct relation" in a tool that shows patches half the
> time is just plain horrible.

Could you be more specific ? AFAIK, 'fetch' symbolism is based on files, the one I need is comparing commits.

And I don't like the '+' either. I chose it because it is the current symbol to show that there is a difference between superproject/submodule.

-- 
=======================================================================
Dr. Ing. Sylvain Joyeux                          sylvain.joyeux@dfki.de
Researcher
DFKI Robotik Lab -- Bremen                   http://www.dfki.de/robotik
Tel: 0049 421 218 64136
=======================================================================
Previous: Andreas EricssonNext: Johannes Schindelin
Message 30 of 34 in “better git-submodule status output”
  1. better git-submodule status outputSylvain Joyeux, Jul 1, 2008
  2. Junio C HamanoJul 6, 2008
  3. Johannes SchindelinJul 6, 2008
  4. Sylvain JoyeuxJul 6, 2008
  5. Johannes SchindelinJul 6, 2008
  6. Sylvain JoyeuxJul 7, 2008
  7. Avery PennarunJul 7, 2008
  8. Johannes SchindelinJul 7, 2008
  9. Johannes SchindelinJul 7, 2008
  10. Sylvain JoyeuxJul 7, 2008
  11. Johannes SchindelinJul 7, 2008
  12. Sylvain JoyeuxJul 7, 2008
  13. Junio C HamanoJul 7, 2008
  14. Avery PennarunJul 7, 2008
  15. Junio C HamanoJul 7, 2008
  16. Sylvain JoyeuxJul 8, 2008
  17. Johannes SchindelinJul 8, 2008
  18. Sylvain JoyeuxJul 8, 2008
  19. Johannes SchindelinJul 8, 2008
  20. Sylvain JoyeuxJul 8, 2008
  21. Avery PennarunJul 7, 2008
  22. Johannes SchindelinJul 7, 2008
  23. Avery PennarunJul 7, 2008
  24. Johannes SchindelinJul 7, 2008
  25. Sylvain JoyeuxJul 7, 2008
  26. Sylvain JoyeuxJul 7, 2008
  27. Mark LevedahlJul 6, 2008
  28. Sylvain JoyeuxJul 9, 2008
  29. Andreas EricssonJul 9, 2008
  30. Sylvain JoyeuxJul 9, 2008
  31. Johannes SchindelinJul 9, 2008
  32. Sylvain JoyeuxJul 9, 2008
  33. Johannes SchindelinJul 9, 2008
  34. Junio C HamanoJul 9, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.