Re: Test breakage [Re: [ANNOUNCE] GIT 1.5.6.2]

From: Jeff King <peff@peff.net>
Date: Jul 8, 2008, 05:16 UTC
Message-ID: <20080708051622.GC2037@sigill.intra.peff.net>
In-Reply-To: <g4t342$9m8$1@ger.gmane.org>

On Mon, Jul 07, 2008 at 02:44:49PM +0200, Michael J Gruber wrote:

Show 14 quoted lines

> On Kubuntu 7.10 (not my choice, this is at work...), "make test" gives:
>
> *** t9600-cvsimport.sh ***
> [...]
> * FAIL 6: update git module
>                 cd module-git &&
>                 git cvsimport -a -z 0 module &&
>                 git merge origin &&
>                 cd .. &&
>                 test_cmp module-cvs/o_fortuna module-git/o_fortuna
>
> On the second (and subsequent) run, "make test" succeeds. I tried again  
> with a fresh copy from the tarball, same effect: failure on 1, success on 
> 2 and following.

I tried reproducing on my Debian box with various weaks of $LANG, but I couldn't. Can you please try running "./t9600-cvsimport.sh -v -i" and send us the output of a failing instance. It's not clear which step in failing test is causing the problem, or if cvsps is giving off any useful errors.

> This is with LANG=de_DE.UTF-8, whereas with LANG=C the tests succeed the  
> first time already. Are tests supposed to be done in C locale only? Do  
> they reuse data from a previous test run? I didn't notice this with 
> 1.5.6.1.

They should be perfectly repeatable, but I have run into problems in the past with cruft in my ~/.cvsps directory. However, we should be setting $HOME properly in t9600 to avoid this, so I'm not sure what the culprit is.

-Peff