Re: [PATCH 1/3] git-imap-send: Allow the program to be run from subdirectories of a git tree.
- From
Jeff King <peff@peff.net>
- Date
- Jul 8, 2008, 04:10 UTC
- Message-ID
- <20080708041037.GB7186@sigill.intra.peff.net>
- In-Reply-To
- <1096648c0807070105l49a6dc38ra1710b0aadb220d9@mail.gmail.com>
On Mon, Jul 07, 2008 at 09:05:22AM +0100, Rob Shearman wrote:
> Call setup_git_directory_gently to allow git-imap-send to be used from > subdirectories of a git tree. > [...] > + setup_git_directory_gently( NULL );
I don't think this is right; now we _must_ be in a git tree to run the command, which was not the case previously. You need to pass a non-NULL parameter to setup_git_directory_gently, which is where it will store the "are we in a git dir" return value (even if you don't want to look at it, if the parameter is NULL, it will die("not a git repository")).
-Peff