git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] git daemon: avoid calling syslog() from a signal handler

From
Stephen R. van den Berg <srb@cuci.nl>
Date
Jul 7, 2008, 06:54 UTC
Message-ID
<20080707065439.GA25877@cuci.nl>
In-Reply-To
<7vmykua2et.fsf@gitster.siamese.dyndns.org>
Junio C Hamano wrote:
>Another thing we might want to consider to make this logic much more
>simpler would be to move everything out of child_handler(), except the
>write() whose sole purpose is to allow us break out of the poll().

As a general rule, keep the work done in a signal handler down to the bare minimum (like setting an integer flag, and perhaps unblocking the main thread through a write to this signallingpipe).

-- 
Sincerely,
           Stephen R. van den Berg.

A truly wise man never plays leapfrog with a unicorn.
Previous: Junio C Hamano
Message 13 of 13 in “Non-inetd git-daemon hangs in syslog(3)/fclose(3) if --syslog --verbose accessing non-repositories”
  1. Brian FosterJul 3, 2008
  2. Johannes SchindelinJul 3, 2008
  3. Brian FosterJul 3, 2008
  4. Johannes SchindelinJul 3, 2008
  5. git daemon: avoid calling syslog() from a signal handlerJohannes Schindelin, Jul 3, 2008
  6. Junio C HamanoJul 5, 2008
  7. Johannes SchindelinJul 5, 2008
  8. Junio C HamanoJul 5, 2008
  9. Johannes SchindelinJul 6, 2008
  10. Junio C HamanoJul 6, 2008
  11. git daemon: avoid calling syslog() from a signal handlerJohannes Schindelin, Jul 6, 2008
  12. Junio C HamanoJul 7, 2008
  13. Stephen R. van den BergJul 7, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.