Re: ':/<oneline prefix>' notation doesn't support full file syntax

From: Jeff King <peff@peff.net>
Date: Jul 3, 2008, 10:47 UTC
Message-ID: <20080703104744.GB26162@sigill.intra.peff.net>
In-Reply-To: <279b37b20807022242q69ad2fcbwb8c11a9d6165272d@mail.gmail.com>

On Wed, Jul 02, 2008 at 10:42:52PM -0700, Eric Raible wrote:

Show 20 quoted lines

> Although the rev-parse documentation claims that the
> tree-ish:path/to/file syntax works is applicable, this is
> not so when using the :/ "oneline prefix" syntax:
> 
> % git rev-parse v1.5.0.1-227-g28a4d94
> 28a4d940443806412effa246ecc7768a21553ec7
> % git rev-parse ":/object name"
> 28a4d940443806412effa246ecc7768a21553ec7
> 
> % git rev-parse v1.5.0.1-227-g28a4d94:sha1_name.c
> 0781477a71ac4d76a1b8783868d6649cae7f8507
> % git rev-parse ":/object name":sha1_name.c
> :/object name:sha1_name.c
> fatal: ambiguous argument ':/object name:sha1_name.c': unknown
> revision or path not in the working tree.
> Use '--' to separate paths from revisions
> 
> A quick look at int sha1_name.c:get_sha1() shows that it doesn't
> even try to make this work.  Is this worth fixing?
> Or at least documenting?

IMHO, :/ should stop eating text at the first ':', and allow '\:' for a literal colon and '\\' for a literal backslash.

I think nobody has really cared up to this point (and I can't say that I care that much now, but I wouldn't object to such a patch).

-Peff