Re: [PATCH 14/14] Build in merge
- From
Miklos Vajna <vmiklos@frugalware.org>
- Date
- Jul 1, 2008, 12:55 UTC
- Message-ID
- <20080701125518.GX4729@genesis.frugalware.org>
- In-Reply-To
- <7vzlp2oyh7.fsf@gitster.siamese.dyndns.org>
On Tue, Jul 01, 2008 at 12:27:48AM -0700, Junio C Hamano <gitster@pobox.com> wrote:
Show 10 quoted lines
> I'll queue the fixed-up result in 'pu', but I have to tend to other topics > before I can actually publish. Together with the fix to "head_invalid" > confusion I mentioned in another message squashed in to this commit, all > the tests now finally seem to pass on the topic branch. > > Oh, by the way, you sent this and the previous round without marking them > as RFC nor WIP, even though they obviously did not even pass the test > suite. For example, without the head_invalid fix, anything that runs > merge on detached head, most notably "git rebase -i", would not work at > all.
Thanks for pointing that out. I remember I used to run 'make test' before sending a patch, but that took a lot of time and then I used to run only t*merge*.sh, which - it turns out - was a bad idea, since I haven't noticed breaking t3404.
I'm now running a full 'make test' before I send the patch.