Re: [PATCH] git-gui: Don't select the wrong file if the last listed file is staged.

From: Shawn O. Pearce <spearce@spearce.org>
Date: Jun 25, 2008, 20:57 UTC
Message-ID: <20080625205702.GN11793@spearce.org>
In-Reply-To: <486222A6.70205@viscovery.net>

Johannes Sixt <j.sixt@viscovery.net> wrote:

Show 12 quoted lines

> Abhijit Menon-Sen schrieb:
> > Johannes Sixt noticed that if the last file in the list was staged, my
> > earlier patch would display the diff for the penultimate file, but show
> > the file _before_ that as being selected.
> > 
> > This was due to my misunderstanding the lno argument to show_diff.
> > 
> > This patch fixes the problem: lno is not decremented in the special case
> > to handle the last item in the list (though we still need to use $lno-1
> > to find the right path for the next diff).
> 
> Thanks. It works here, too:

Thanks, both.  Its in my tree.

-- 
Shawn.