Re: [PATCH] pack.indexversion config option now defaults to 2

From: Mike Hommey <mh@glandium.org>
Date: Jun 25, 2008, 06:14 UTC
Message-ID: <20080625061453.GA32178@glandium.org>
In-Reply-To: <7viqvy59qr.fsf@gitster.siamese.dyndns.org>

On Tue, Jun 24, 2008 at 11:06:36PM -0700, Junio C Hamano wrote:

Show 15 quoted lines

> Mike Hommey <mh@glandium.org> writes:
> 
> > Wouldn't it be a good idea to add a warning in git update-server-info
> > when it detects pack.indexVersion is not 1, too ?
> 
> Can you describe how that warning will help whom in the bigger picture?
> 
> The way as I understand everybody runs "git update-server-info" is:
> 
>  * "git push" pushes into a publishing repository, then
>  * "post-receive" (or "post-update") hook triggers "update-server-info".
> 
> If you spit out a warning from update-server-info, it will be shown to the
> pusher over sideband, but this will not necessarily help the pusher, who
> may or may not have shell access to the repository.

There are also those that get the message to run update-server-info when trying to clone over dumb protocol when the info/refs file is not there... I actually didn't think about the post-receive hook.

Well, then, update-server-info could output the warning only if stderr is a tty.

Mike