Re: git svn --use-log-author misbehavior?

From: Fredrik Skolmli <fredrik@frsk.net>
Date: Jun 20, 2008, 10:57 UTC
Message-ID: <20080620105729.GB27940@frsk.net>
In-Reply-To: <485B82BD.2000404@mircea.bardac.net>

On Fri, Jun 20, 2008 at 11:13:17AM +0100, Mircea Bardac wrote:

Show 18 quoted lines

> I haven't tested this yet but I have a feeling this is not my case, or I 
> might not be fully understanding the implications of "--add-author-from" 
> on the functionality of "--use-log-author". Technically, they should be 
> independent and the options should not depend on each other:
> * --use-log-author only applies to getting info from the commits
> * --add-author-from only applies to putting info in the commits
> 
> From the documentation, these 2 options can only be used with git svn 
> init/clone so they should somehow be saved for future use. Maybe this 
> doesn't happen.
> 
> My Git commits (not dcommits) already have "Signed-off-by:" at the end, 
> added with "git commit -s". When I do a "git svn dcommit" they get 
> pushed to SVN and the entire commit is rewritten. I have 
> --add-author-from added on git clone, but nothing else is being added to 
> the commit except the git-svn-id - from my point of view, according to 
> the documentation, this is the correct behavior (since there already is 
> a Signed-off-by line)

 
Did you mean "git svn clone" here, not "git clone"? And if --use-log-author
is to be used to get retrieve info from the commits, it should be used
instead of --add-author-from when doing a clone. (Which as far as I can see
behaves correctly.)

However, looks like I might have misunderstood your problem, and possibly found a bug in the process. I'll look closer into it. :-)

-- 
Regards,
Fredrik Skolmli