Re: [JGIT] fnmatch Implementation.

From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Date: Jun 18, 2008, 18:43 UTC
Message-ID: <200806182043.43321.robin.rosenberg.lists@dewire.com>
In-Reply-To: <4858DFA2.30203@web.de>

onsdagen den 18 juni 2008 12.12.50 skrev Florian Köberle:

Show 5 quoted lines

> Hi,
> 
> when I send a large list of patches and one is wrong then you don't
> accept any. That's why I now will try to get one patch in before I send
> the next one.

Patience please. When there is long series it *will* take time for a number of reasons. Most have nothing to do with this project at all. But in general you will find a short patch series *much* easier to get through than a long one.

If you think my grouping is ok, then ack and I can commit from there. I was thinking of actually adding some test myself, but that's all I had in mind.

Show 7 quoted lines

> The first patch I will commit this way is the fnmatch patch.
> 
> As suggested by Robin I replaced unicode characters not included in the
> ASCII set with \uXXXX sequences.
> 
> I also added some more test cases and improved the javadoc of the
> FileNameMatcher class.

That's good.

> 
> Best regards,
> Florian
>