Re: [PATCH 1/2] git add: add long equivalents of '-u' and '-f' options

From: SZEDER Gábor <szeder@ira.uka.de>
Date: Jun 15, 2008, 21:23 UTC
Message-ID: <20080615212329.GB7003@neumann>
In-Reply-To: <7vlk16cuu2.fsf@gitster.siamese.dyndns.org>

On Sun, Jun 15, 2008 at 01:21:57PM -0700, Junio C Hamano wrote:

Show 7 quoted lines

> SZEDER Gábor <szeder@ira.uka.de> writes:
> > I think this patch is rather a bugfix in the user interface than a new
> > feature.
> 
> Strictly speaking, this is a new feature but I think the documentation
> value to clarify -u stands for "update" is great enough to make it an
> exception.

Well, my reasoning was that every short option must have a long equivalent, therefore the lack of long options is a bug (even if this does not lead to e.g. a runtime error).

> I've rewritten (from empty!  Szeder, next time please write
> sensible commit log message to defend your changes, instead of having _me_
> to defend your changes to others here, like this) the commit log message
> to clarify this point.

Sorry, I though the rationale behind the changes (i.e. "why?") is trivial even from that one-liner: add long options, because, well, they do not exist. In fact, I considered to write something like "these long options are '--update' and '--force'" in the commit message. But I dropped it, because that explained _what_ the patch does, and I understood that that should not go into the commit message.

Anyway, I will take care next time.

Regards, Gábor