Re: [EGIT RFC] Commit behaviour

From: Robin Rosenberg <robin.rosenberg@dewire.com>
Date: Jun 14, 2008, 10:23 UTC
Message-ID: <200806141223.11134.robin.rosenberg@dewire.com>
In-Reply-To: <4852EFBF.6000406@gmail.com>

lördagen den 14 juni 2008 00.07.59 skrev Marek Zawirski:

Show 5 quoted lines

> Theses patches don't work for me however :/ When I introduce some change 
> to a resource/file, even add it to index and click commit (toolbar or 
> menu), commit action does nothing. It is - nothing happens. Can you 
> reproduce this problem, or should I debug it on my instance? Or do I use 
> it in some wrong way?

Found it. Obviously this won't work for commits to multiple repositories which is supposed to work really, but I think that was broken earlier by yours truly. This fix should make it possible to test the idea though this thread is about, and see if we have more selection problems.

-- robin

diff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/actions/CommitAction.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/actions/CommitAction.java
index da32ea5..922649b 100644
--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/actions/CommitAction.java
+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/actions/CommitAction.java
@@ -124,7 +124,7 @@ public class CommitAction extends RepositoryAction {
        }

        private void loadPreviousCommit() {
-               IProject project = getSelectedProjects()[0];
+               IProject project = getProjectsForSelectedResources()[0];

                Repository repo = RepositoryMapping.getMapping(project).getRepository();
                try {