Re: [StGit PATCH] compressed import v3

From: Karl Hasselström <kha@treskal.com>
Date: Jun 13, 2008, 05:11 UTC
Message-ID: <20080613051127.GA24245@diana.vm.bytemark.co.uk>
In-Reply-To: <48519602.2090103@gmail.com>

On 2008-06-12 16:32:50 -0500, Clark Williams wrote:

> Attached is my latest stab at StGit importing patches from
> compressed files. This version doesn't try to differentiate by the
> file extension; it just tries to open gzip or bz2 files and if those
> fail it reverts to text.

Very good!

> I'm not completely happy with it, but I've spent about as much time
> on it as I can afford to (for this week anyway).

Heh. I see an opportunity for condensing the code a bit in __gethandleandname(), and you intented the "pass"es funny, but I'll take care of it (or not, seeing as they're kind of minor nits -- in any case, I'll just take the patch off your hands and stop tormenting you about it).

> Yeah, yeah, Karl, there are four new tests in t1800-import. Let me
> know if you think there should be more (more for compressed input
> that is; I'm not crazy enough to sign up to write more tests for
> *everything*). :)

No, this is exactly what I was aiming for.

Bleed 'em dry, but _no more_! ;-)

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle