Re: [JGIT PATCH v3 19/23] Added WorkTree class which can be constructed over Repository.
- From
Robin Rosenberg <robin.rosenberg.lists@dewire.com>
- Date
- Jun 6, 2008, 00:23 UTC
- Message-ID
- <200806060223.07384.robin.rosenberg.lists@dewire.com>
- In-Reply-To
- <1211574872-23676-20-git-send-email-florianskarten@web.de>
fredagen den 23 maj 2008 22.34.28 skrev Florian Koeberle:
Show 21 quoted lines
> ---
> .../src/org/spearce/jgit/lib/Repository.java | 57 +++++++++++++++++
> .../src/org/spearce/jgit/lib/WorkTree.java | 67 ++++++++++++++++++++
> 2 files changed, 124 insertions(+), 0 deletions(-)
> create mode 100644 org.spearce.jgit/src/org/spearce/jgit/lib/WorkTree.java
>
> diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/Repository.java b/org.spearce.jgit/src/org/spearce/jgit/lib/Repository.java
> + public Commit setupHEADRef(final String remoteBranch, final String branch)
> + throws IOException {
> + Commit mapCommit = mapCommit(remoteBranch);
> + String refName = Constants.HEADS_PREFIX + "/" + branch;
> + LockFile masterRef = lockRef(refName);
> + try {
> + masterRef.write(mapCommit.getCommitId());
> + masterRef.commit();
> + } finally {
> + masterRef.unlock();
> + }
> + writeSymref(Constants.HEAD, refName);
> + return mapCommit;
> + }Shouldn't someone be calling this?
Show 7 quoted lines
> diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/WorkTree.java b/org.spearce.jgit/src/org/spearce/jgit/lib/WorkTree.java
> + /**
> + * Closes the git repository of this project.
> + */
> + public void closeRepository() {
> + repository.close();
> + }This is redundant. Very few callers need it and those can just as well call getRepsitory().close() anyway.