Re: [PATCH] handle http urls with query string ("?foo") correctly

From: David ‘Bombe’ Roden <bombe@pterodactylus.net>
Date: Jun 5, 2008, 08:37 UTC
Message-ID: <200806051037.58675.bombe@pterodactylus.net>
In-Reply-To: <7vtzg82u18.fsf@gitster.siamese.dyndns.org>

On Thursday 05 June 2008 09:57:39 Junio C Hamano wrote:

Show 6 quoted lines

> my understanding is that this peculiar http-hosted git repository
> takes:
> 	http://foo.bar.xz/serve.cgi?repo=foo.git/
> as the base URL, and the patch author wants us to ask for (for example)
> "info/alternates" as
> 	http://foo.bar.xz/serve.cgi/info/alternates?repo=foo.git/

Actually the base URL is more like

	http://foo.bar.xz/foo.git/0?type=text/plain

and I want to retrieve objects with

	http://foo.bar.xz/foo.git/0/info/refs?type=text/plain

but the gist is basically the same. My patch will indeed break git for URLs like the one you gave.

Show 7 quoted lines

>  (2) If that is indeed the issue being tackled, sorry, it is not how "dumb
>      protocol" http server is expected to behave.  Your server needs
>      fixing.
> If the protocol being used is still the "dumb commit walker" protocol,
> then, given the base URL of the repository $URL, "info/refs" must exist at
> "$URL/info/refs", and a loose object deadbeef... must exist at
> "$URL/objects/de/adbeef...".  That's how the protocol is defined.

If that is indeed the case, you're right. That could probably be tackled by some small fixes in Freenet's http-gateway. I'll talk to the other developers about that.

Thanks,

	David