Re: [PATCH] describe match pattern for soft tags too

From: Shawn O. Pearce <spearce@spearce.org>
Date: Jun 3, 2008, 22:48 UTC
Message-ID: <20080603224839.GO12896@spearce.org>
In-Reply-To: <alpine.LNX.1.10.0806031957360.3605@pollux>

Michael Dressel <MichaelTiloDressel@t-online.de> wrote:

> 
> So far git describe --match <pattern> would apply the <pattern> only
> to tag objects not to soft tags. This change make describe apply
> the <pattern> to soft tags too.

Whoops.

Signed-off-by tag?

Assuming you supply Junio an SBO tag,

Acked-by: Shawn O. Pearce <spearce@spearce.org>

Show 22 quoted lines

> ---
>  builtin-describe.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/builtin-describe.c b/builtin-describe.c
> index df554b3..a1b8251 100644
> --- a/builtin-describe.c
> +++ b/builtin-describe.c
> @@ -82,10 +82,10 @@ static int get_name(const char *path, const unsigned 
> char *sha1, int flag, void
>  	if (might_be_tag) {
>  		if (is_tag) {
>  			prio = 2;
> -			if (pattern && fnmatch(pattern, path + 10, 0))
> -				prio = 0;
>  		} else
>  			prio = 1;
> +		if (pattern && fnmatch(pattern, path + 10, 0))
> +			prio = 0;
>  	}
>  	else
>  		prio = 0;

-- 
Shawn.